fix: chectl improvements #948
Conversation
tolusha
force-pushed
the
someimprovements
branch
from
25ed3f4
to
69e1c76
Compare
| }), | ||
| 'skip-kubernetes-health-check': skipKubeHealthzCheck | ||
| 'skip-kubernetes-health-check': skipKubeHealthzCheck, | ||
| yes: assumeYes |
There was a problem hiding this comment.
assume is more general then confirmation
| }), | ||
| platform: string({ | ||
| char: 'p', | ||
| description: 'Type of Kubernetes platform. Valid values are \"minikube\", \"minishift\", \"k8s (for kubernetes)\", \"openshift\", \"crc (for CodeReady Containers)\", \"microk8s\".', | ||
| options: ['minikube', 'minishift', 'k8s', 'openshift', 'microk8s', 'docker-desktop', 'crc'], | ||
| hidden: true, |
There was a problem hiding this comment.
Isn't it a required parameter?
There was a problem hiding this comment.
No, it is not required.
We hide it since it isn't used.
There was a problem hiding this comment.
Maybe, then, we have to delete it at all?
There was a problem hiding this comment.
Let's keep it for backward compatibility
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, mmorhun, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
New changes are detected. LGTM label has been removed. |
tolusha
force-pushed
the
someimprovements
branch
2 times, most recently
from
463e025
to
3b82471
Compare
|
/test v4-chectl-e2e |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
tolusha
force-pushed
the
someimprovements
branch
from
5b36291
to
cbfa941
Compare
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
check to runoc status` for default namespace-yflag for confirmation, others flag marked as hidden.server:updatecommand platform independent (the corresponding flags are hidden)PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.